-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
indexer-cli: add the --fields option #547
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! If we can remove the need for the hardcoded array of fields that'd be great!
Also, could you add a few actions get ...
tests? One for successful use of --fields and at least one for the failure modes? Similar to the rules get tests we already have.
As of 14b6176, tests fail when interacting with the GraphQL library.
I'm not sure what's the cause of this problem. This is the query result object, for reference:
|
6c3a111
to
8448e4c
Compare
Included some tests for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
I only have a few message formatting suggestions now. 😄
...and a reminder to rebase or squash commits before rebase&merge, so we're left with a readable, meaningful commit history!
bc4e412
to
e9ed321
Compare
Squashed and rebased commits for a more concise history |
This PR introduces the
--fields
option to theindexer actions get
subcommand.Filed names passed to this option will be used to select the columns displayed in stdout after the Actions query resolves.
For instance, passing the
--fieds id,type,source,transaction
will produce the following output.